Fix action-plugin-docs sanity for junos action plugins#830
Open
malikdotexe wants to merge 3 commits into
Open
Conversation
rohitthakur2590
requested review from
dineshbaburam91,
komaldesai13 and
rohitthakur2590
malikdotexe
force-pushed
the
fix/junos-action-plugin-sanity
branch
2 times, most recently
from
d31ad90 to
97f6f2d
Compare
Rename juniper.device action plugins to junos_* names matching their modules, add plugin_routing.action redirects for short aliases, and mirror action redirects in junipernetworks.junos runtime.yml so deprecated FQCNs keep working. Add ignore-2.21.txt for Ansible 2.21 sanity.
Restructure RETURN docstrings in junos_banner, junos_system, junos_user, and junos_vrf to use a properly nested dict for `diff.prepared` instead of a dotted flat key. Remove the corresponding ignore-2.21.txt entries since these modules (from the junipernetworks.junos merger) should not carry sanity ignores.
malikdotexe
force-pushed
the
fix/junos-action-plugin-sanity
branch
from
97f6f2d to
921d5ec
Compare
Collaborator
|
@dineshbaburam91 could you help us giving maintainers acces for @malikdotexe |
Add plugin_routing.action and modules redirects for l2_interfaces and lag_interfaces in juniper.device runtime.yml. Bump unit-source devel and milestone matrix jobs to Python 3.13 for ansible-core devel compatibility.
rohitthakur2590
approved these changes
Jun 23, 2026
Collaborator
|
now that @malikdotexe have tested this locally, @chidanandpujar @dineshbaburam91 could you also prlease review this and also validate through integration tests at your end as well. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
juniper.deviceaction plugins tojunos_*names so each action matches its module (action-plugin-docssanity).plugin_routing.actionredirects injuniper.device/meta/runtime.ymlfor short aliases (e.g.interfaces→junos_interfaces).plugin_routing.actionentries injunipernetworks.junos/meta/runtime.ymlso playbooks using deprecatedjunipernetworks.junos.*FQCNs still resolve actions to the renamed plugins injuniper.device.tests/sanity/ignore-2.21.txtfor Ansible 2.21 (helper actions + pre-existingbad-return-value-keymodule doc issues).Sanity test report (local,
ansible-core2.21)Collection:
ansible_collections/juniper/deviceCommand:
ansible-test sanity(from collection root)action-plugin-docsmaster)ansible-test sanity --test action-plugin-docs(noignore-2.21.txt)extract_data.py,juniper_junos_common_action.pyignore-2.21.txt(same 2 helper ignores only)plugins/action/*.pyvs modules)interfaces.pyvsjunos_interfacesmodule,logging.py, helpers)logging.py,extract_data.py,juniper_junos_common_action.py) — 27 resource-action mismatches fixed by renameNote: On
master,ansible-testonly reported 2 failures because most short-name actions are symlinks (interfaces.py→junos.py); the checker does not flag symlink names the same way as a full path scan. Renames fix the real naming mismatch regardless.action-plugin-docsignores: unchanged forignore-2.16…ignore-2.20(still only the two helper actions). No ignores added or removed for renamedjunos_*resource actions. Nojunos.pyignore —plugins/modules/junos.pyexists.Full sanity (
ansible-test sanity, all 34 tests)master)ignore-2.21.txtaction-plugin-docs,validate-modules, …)ignore-2.19copied asignore-2.21onlyvalidate-modulesincl. 4×bad-return-value-key,importon py3.11–3.14)ignore-2.21.txtin PRjunipernetworks/junos(shim)yamllint,runtime-metadataTest plan
ansible-test sanitypasses onansible_collections/juniper/device(withignore-2.21.txt)ansible-test sanity --test yamllint --test runtime-metadatapasses onansible_collections/junipernetworks/junosansible-test sanity --test action-plugin-docspasses onjuniper.device(ignores only forextract_dataandjuniper_junos_common_action)